mark dataset factory as private

dlt-hub · Oct 14, 2024 · 9354e86 · 9354e86
1 parent f49c3ca
commit 9354e86
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/dlt/__init__.py b/dlt/__init__.py
@@ -42,7 +42,7 @@
 )
 from dlt.pipeline import progress
 from dlt import destinations
-from dlt.destinations.dataset import dataset
+from dlt.destinations.dataset import dataset as _dataset
 
 pipeline = _pipeline
 current = _current
@@ -80,7 +80,7 @@
     "TCredentials",
     "sources",
     "destinations",
-    "dataset",
+    "_dataset",
 ]
 
 # verify that no injection context was created

diff --git a/tests/load/test_read_interfaces.py b/tests/load/test_read_interfaces.py
@@ -221,7 +221,7 @@ def double_items():
     )
 
     # check dataset factory
-    dataset = dlt.dataset(destination=destination_for_dataset, dataset_name=pipeline.dataset_name)
+    dataset = dlt._dataset(destination=destination_for_dataset, dataset_name=pipeline.dataset_name)
     # verfiy that sql client and schema are lazy loaded
     assert not dataset.schema
     assert not dataset.sql_client
@@ -232,7 +232,7 @@ def double_items():
     # check that schema is loaded by name
     dataset = cast(
         ReadableDBAPIDataset,
-        dlt.dataset(
+        dlt._dataset(
             destination=destination_for_dataset,
             dataset_name=pipeline.dataset_name,
             schema=pipeline.default_schema_name,
@@ -244,7 +244,7 @@ def double_items():
     # check that schema is not loaded when wrong name given
     dataset = cast(
         ReadableDBAPIDataset,
-        dlt.dataset(
+        dlt._dataset(
             destination=destination_for_dataset,
             dataset_name=pipeline.dataset_name,
             schema="wrong_schema_name",
@@ -257,7 +257,7 @@ def double_items():
     # check that schema is loaded if no schema name given
     dataset = cast(
         ReadableDBAPIDataset,
-        dlt.dataset(
+        dlt._dataset(
             destination=destination_for_dataset,
             dataset_name=pipeline.dataset_name,
         ),
@@ -269,7 +269,7 @@ def double_items():
     # check that there is no error when creating dataset without schema table
     dataset = cast(
         ReadableDBAPIDataset,
-        dlt.dataset(
+        dlt._dataset(
             destination=destination_for_dataset,
             dataset_name="unknown_dataset",
         ),
@@ -292,7 +292,7 @@ def double_items():
 
     dataset = cast(
         ReadableDBAPIDataset,
-        dlt.dataset(
+        dlt._dataset(
             destination=destination_for_dataset,
             dataset_name=pipeline.dataset_name,
         ),