Skip to content

Commit

Permalink
undo suppress of schema delete
Browse files Browse the repository at this point in the history
  • Loading branch information
sh-rp committed Oct 14, 2024
1 parent 3a1f9a4 commit 8327ebe
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions dlt/destinations/job_client_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -649,12 +649,9 @@ def _delete_schema_in_storage(self, schema: Schema) -> None:
Delete all stored versions with the same name as given schema.
Fails silently if versions table does not exist
"""
with suppress(DatabaseUndefinedRelation):
name = self.sql_client.make_qualified_table_name(self.schema.version_table_name)
(c_schema_name,) = self._norm_and_escape_columns("schema_name")
self.sql_client.execute_sql(
f"DELETE FROM {name} WHERE {c_schema_name} = %s;", schema.name
)
name = self.sql_client.make_qualified_table_name(self.schema.version_table_name)
(c_schema_name,) = self._norm_and_escape_columns("schema_name")
self.sql_client.execute_sql(f"DELETE FROM {name} WHERE {c_schema_name} = %s;", schema.name)

def _update_schema_in_storage(self, schema: Schema) -> None:
# get schema string or zip
Expand Down

0 comments on commit 8327ebe

Please sign in to comment.