Updated - Color warning placement fix #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for alt text generator
Update text replacement
Update text replacement
Added a new function to find indexes of all elements found. Added a new variable to pass in the checkContrast function (index)
Iterates through parent elements to get the background color rather than just using the background by default
made it include to check for the ">" also To pass certain issues such as having the text be element types (i.e. div, p, etc)
Refactored the getIndexes function to make use of regex to read line breaks allowing Added a isThereNoText function to skip checking contrast issues if there is no text
made the callers that call this go straight to getContrastRatio
value being passed to the function was already converted to hex so no need to check other types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new function to find indexes of all elements found.
Added a new variable to pass in the checkContrast function (index)