Simplify MobileCategoryHeader instantiation #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant overriden method `goBackLink()` from `MobileCategoryHeader` in all details pages. This simplifies how `MobileCategoryHeader` is instantiated, reducing code duplication and making the code more maintainable.
The image bindings that previously set header images for various detailed pages have been removed. As the specific line of code setting these bindings was removed in each of the detail pages, the headers for these pages will no longer display preview images based on their respective objects (e.g., tutorial, person, video, tip, book, blog, app, tool, library).
dlemmermann
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goBackLink()fromMobileCategoryHeaderin all details pages. This simplifies howMobileCategoryHeaderis instantiated, reducing code duplication and making the code more maintainable.