Removed call to ServiceLock that checked lock data equivalence (apach…

…e#5291) Closes apache#5288
dlmarion · Jan 29, 2025 · 712e50e · 712e50e
1 parent 7f8f120
commit 712e50e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 29 deletions.
diff --git a/core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ServiceLock.java b/core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ServiceLock.java
@@ -18,7 +18,6 @@
  */
 package org.apache.accumulo.core.fate.zookeeper;
 
-import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.util.Objects.requireNonNull;
 
 import java.util.ArrayList;
@@ -736,33 +735,6 @@ public static void deleteLock(ZooReaderWriter zk, ServiceLockPath path)
 
   }
 
-  public static boolean deleteLock(ZooReaderWriter zk, ServiceLockPath path, String lockData)
-      throws InterruptedException, KeeperException {
-
-    List<String> children = validateAndSort(path, zk.getChildren(path.toString()));
-
-    if (children.isEmpty()) {
-      throw new IllegalStateException("No lock is held at " + path);
-    }
-
-    String lockNode = children.get(0);
-
-    if (!lockNode.startsWith(ZLOCK_PREFIX)) {
-      throw new RuntimeException("Node " + lockNode + " at " + path + " is not a lock node");
-    }
-
-    byte[] data = zk.getData(path + "/" + lockNode);
-
-    if (lockData.equals(new String(data, UTF_8))) {
-      String pathToDelete = path + "/" + lockNode;
-      LOG.debug("Deleting all at path {} due to lock deletion", pathToDelete);
-      zk.recursiveDelete(pathToDelete, NodeMissingPolicy.FAIL);
-      return true;
-    }
-
-    return false;
-  }
-
   /**
    * Checks that the lock still exists in ZooKeeper. The typical mechanism for determining if a lock
    * is lost depends on a Watcher set on the lock node. There exists a case where the Watcher may

diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java b/server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java
@@ -141,7 +141,9 @@ public void zap(SiteConfiguration siteConf, String... args) {
           } else {
             var zLockPath = ServiceLock.path(tserversPath + "/" + child);
             if (!zoo.getChildren(zLockPath.toString()).isEmpty()) {
-              if (!ServiceLock.deleteLock(zoo, zLockPath, "tserver")) {
+              try {
+                ServiceLock.deleteLock(zoo, zLockPath);
+              } catch (RuntimeException e) {
                 message("Did not delete " + tserversPath + "/" + child, opts);
               }
             }