Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MER<> for CreateSpace and return Conflict/Created responses #912

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

p-kaczynski
Copy link
Contributor

Resolves #911

The check for ID seems to not be needed:
API.Features.Space.Converters.SpaceConverter.ToHydra
calls
DLCS.HydraModel.Space.Space_ctor
calls
DLCS.HydraModel.DlcsResource.Init
sets:

Id = BaseUrl + string.Format(uriTemplate, urlParams);

which uses:

[HydraClass(typeof(SpaceClass),
       Description = (snip),
       UriTemplate = "/customers/{0}/spaces/{1}")]
[Unstable(Note = "Under active development")]
public class Space...

@p-kaczynski p-kaczynski merged commit 94640df into main Nov 13, 2024
9 checks passed
@p-kaczynski p-kaczynski deleted the bugfix/911/409_create_space branch November 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create space should return 409 if name is taken
2 participants