Partially revert #303 until #317 is resolved #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
CyberShadow
approved these changes
Feb 13, 2018
|
Good idea, by reverting the new feature for now we can delay the decision on what to support. |
marler8997
approved these changes
Feb 13, 2018
WebDrake
reviewed
Feb 13, 2018
| // Revert https://github.com/dlang/tools/pull/303 until | ||
| // https://github.com/dlang/tools/pull/317 has been resolved | ||
| //if (code.length > 0 && code[$ - 1] != ';') | ||
| //code ~= ';'; |
@wilzbach I would like to understand how you came to the conclusion that you were reverting the functional changes of #303, because I thought I'd been pretty clear (and detailed) about what that PR was changing and why. It wasn't #303 that introduced the idea of auto-appending a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the functional changes of #303, but keeps the refactoring.
Motivation:
In #317 we might figure out a way to be smarter about lines without a semi-colon,
so publishing this now would limit our abilities to change the behavior later.
The master-stable branch-off is supposed to happen in two days, so a quick pull would be appreicated.
Thanks!
CC @CyberShadow @marler8997 @WebDrake