-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper symbol qualifier to function symbols #758
Conversation
✅ This PR fixes following deprecations:
Total deprecations: 110 Total warnings: 4 Build statistics: statistics (-before, +after)
client size=1048544 bin/dcd-client
server size=3085624 bin/dcd-server
-rough build time=62s
+rough build time=63s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.87
-DCD run_tests.sh Maximum resident set size (kbytes): 43464
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.89
+DCD run_tests.sh Maximum resident set size (kbytes): 49224
short requests: (230x)
min request time = 0.009ms
- 10th percentile = 0.118ms
- median time = 0.350ms
- 90th percentile = 0.599ms
- max request time = 1.554ms
+ 10th percentile = 0.112ms
+ median time = 0.358ms
+ 90th percentile = 0.634ms
+ max request time = 1.531ms
long requests over 10ms: (51x)
- min request time = 11.559ms
- 10th percentile = 12.578ms
- median time = 13.871ms
- 90th percentile = 16.515ms
- max request time = 21.736ms
+ min request time = 11.693ms
+ 10th percentile = 12.292ms
+ median time = 13.962ms
+ 90th percentile = 17.198ms
+ max request time = 21.702ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
78109696 843 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
15257216 476788 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
14316800 164422 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
9773344 305417 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7371616 281 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../.dub/packages/msgpack-d/1.0.4/msgpack-d/src/msgpack/common.d:628 Full build output
|
does this fix anything? no test results have changed |
It doesn't change anything, it's mostly used for symbol lookup, i need this to add new inlay hints feature to DCD At best, this probably will fix some existing bugs I'll check around and see what kind of tests i can add |
No description provided.