Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/litener #1

Merged
merged 35 commits into from
Sep 1, 2023
Merged

Feature/litener #1

merged 35 commits into from
Sep 1, 2023

Conversation

MarkCherepovskyi
Copy link
Member

No description provided.

type: object
$ref: '#/components/schemas/TxBlob'
relationship:
type: object

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be jsonapi

config.yaml Outdated

listener:
addr: :8000

networks:
list:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keys

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all generated files to pkg directory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all generated files to pkg directory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all generated files to pkg directory


for _, info := range txHashes {
tx := block.Transaction(info.TxHash)
l.log.Debug(hex.EncodeToString(tx.Data()))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comment to debug log

}

func (l *ListenData) parsePayloadOnInput(input string, header string, footer string) ([]string, error) { //move to another class
index := strings.Index(input, header)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment on what this function do

}

func (c *networkconfiger) Network() *Network {
return c.once.Do(func() interface{} {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need to create initially connections(it's a question)

return nil, errors.Wrap(err, "failed to send request")
}

if resp.StatusCode >= 300 && resp.StatusCode < 500 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5xx are errors too + please log some details also

decodedResponse := new(NetworkListResponse)

if err := json.NewDecoder(resp.Body).Decode(&decodedResponse); err != nil {
return nil, errors.New("failed to decode response ")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap erorr

PRIMARY KEY (payment_id)
);


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add indexes

.goalngci.yml Outdated
@@ -0,0 +1,1325 @@
linters-settings:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file


}

func (l *ListenData) run(ctx context.Context) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add debug logs for runner

@MarkCherepovskyi MarkCherepovskyi merged commit 3dacd54 into dev Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants