Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zend extensions now supported in php cookbook #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Sep 15, 2012

https://github.com/opscode-cookbooks/php/blob/master/CHANGELOG.md#v110

I'll submit a PR that makes use of the extension.ini.erb template

…tr (php cookbook => 1.1.0). Nested directive cookbook attrs. Allowed unpinned version by default.
@patcon
Copy link
Contributor Author

patcon commented Sep 15, 2012

Ok so, this should solve oriuminc/vagrant-ariadne#9

Hopefully it wasn't overstepping, but I also removed the default setting of the version attr. (@msonnabaum convinced me of the errors in my ways somewhere along the line). If we set a default, then we need to update the cookbook with version bumps, so it's better to default to nil, but allow other to set if they need to.

And thanks for maintaining this, xforty guys! :)

@patcon
Copy link
Contributor Author

patcon commented Sep 15, 2012

Hopefully not to far off-course, but in testing, realized that building xdebug with pear required at least make so resolved that by including build essential cookbook and adding a dep to metadata.

patcon added a commit to oriuminc/vagrant-ariadne that referenced this pull request Sep 15, 2012
@djoos
Copy link
Member

djoos commented Jan 27, 2014

Hi @patcon,

I'm the new maintainer of the xdebug cookbook and I hope to get back to you on this PR within the next few weeks...

Kind regards,
David

@patcon
Copy link
Contributor Author

patcon commented Jan 27, 2014

Rockin 👍

I'm not using it right now, so I likely won't be able to put further work into it unfortunately.

@djoos djoos self-assigned this Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants