modifications #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) but principally these changes: * added 'debugLevel' option (default 0=none, 1=once per load, 2=once per drag, 3=firehose) * added 'dragElementCenter' option (default false=mouse drags element top, true=mouse drags element vertical center) * added concept of constraining dragged item to it's parent element, via three options: - 'constrain' (default false=can drag without restriction, true=dragging limited to parent top and bottom, true=apply following two options) - 'constrainMarginTop (default 0, distance inside parent from top where dragging is forbidden) - 'constrainMarginBottom (default 0, same as constrainMarginTop but from the bottom) * ran the script through JSLint and accepted the fact that my feelings would be hurt in exchange for a variety of small fixes reducing logic and whitespace ambiguity.
… with the 'sortable-' prefix, replacing 'sorting', 'active', and 'active-drag-item') with more sensible names; * Added css file with some default styles, and moved the application styles that were in css() calls here too.
|
Alright with this new commit I cover up a couple problems with the previous one so if you care to, it's safe to merge. However it will break as a drop in replacement for yours since I changed the class names and moved the styles to a stylesheet. |
…ge if it's part of a nested structure; Don't manually set opacity, do it in the css class;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.