Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the hover effect for social media icons #219

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed the hover effect for social media icons #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
babd46b
Resolve the hover color issue
Neel-07 Sep 26, 2023
e969e84
Resolved the hover color change issue
Neel-07 Sep 26, 2023
339a3d6
Resolved the white hover color of the website icon
Neel-07 Sep 26, 2023
f6423ba
revert the changes made and added .web hover, change the color of git…
Neel-07 Sep 28, 2023
f7cf3ec
changed mastodon and web fill color
Neel-07 Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
source "https://rubygems.org"

gem 'wdm', '>=0.1.0 '
gem "webrick"

gem "github-pages", group: :jekyll_plugins
gem "tzinfo-data"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these changes needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your feedback. I included the tzinfo-data gem in the Gemfile because it is a dependency for the tzinfo gem, which is used for time zone conversions. The tzinfo gem can use either the system zoneinfo files or the Ruby modules from the tzinfo-data gem as the data source. However, on Windows systems, the system zoneinfo files are not available, so the tzinfo-data gem is required. Therefore, I added the tzinfo-data gem to ensure that the application can access the correct time zone information on any platform. I hope this clarifies your question. Also, I was getting errors while running the bundle exec jekyll serve command without the tzinfo-data gem, so I had to include it to make the site work locally.

4 changes: 2 additions & 2 deletions _src/scss/_settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ $color-linkedin: #2b75b2;
$color-pinterest: #CF3132;
$color-youtube: #E4251A;
$color-google-plus: #D55441;
$color-github: #4078c0;
$color-mastodon: #3088D4;
$color-github: #000000;
$color-mastodon: #6364ff;
$color-rss: #FD8A22;

// 1. Global
Expand Down
4 changes: 2 additions & 2 deletions _src/scss/module/_social-icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
fill: $primary-color;
}

&:hover svg {
fill: $white;
&.web:hover svg {
fill: $black;
}

&.facebook:hover svg {
Expand Down
109 changes: 46 additions & 63 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
"css-loader": "^6.7.1",
"mini-css-extract-plugin": "^2.6.1",
"resolve-url-loader": "^3.1.1",
"sass": "^1.62.1",
"sass-loader": "^13.0.2",
"webpack": "^5.80.0",
"sass": "^1.68.0",
"sass-loader": "^13.3.2",
"webpack": "^5.88.2",
"webpack-cli": "^4.10.0"
},
"scripts": {
Expand Down