Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view to delete current logged in user #1786

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bmispelon
Copy link
Member

@bmispelon bmispelon commented Dec 1, 2024

Refs #1782

I also added two other small commits on the same branch:

  • 60eb512 changes the on_delete value of BoardMember.account to PROTECT to avoid users being able to delete their active board memberships
  • f4234de doesn't send a default next value of / when logging in. Doing so bypasses the standard settings.LOGIN_REDIRECT_URL and makes it harder for users to discover their profile edit page (which is already hard to discover)

Here are some screenshots of the new pages that were added (light mode only):
confirmation page:
Screenshot 2024-12-01 at 17-31-59 Confirmation delete your profile Django

error page:
Screenshot 2024-12-01 at 17-52-38 Confirmation delete your profile Django

success page:
Screenshot 2024-12-01 at 18-00-23 The web framework for perfectionists with deadlines Django

Setting it to "/" by default makes settings.LOGIN_REDIRECT_URL
useless, and makes the profile edit page harder to discover.
@bmispelon bmispelon marked this pull request as ready for review December 1, 2024 17:02
@bmispelon bmispelon changed the title Add view to deleting current logged in user Add view to delete current logged in user Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant