-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump django-hosts from 5.1 to 6.0 in /requirements #1598
base: main
Are you sure you want to change the base?
Conversation
@dependabot recreate |
1308231
to
09b577a
Compare
This commit in django-hosts includes the change that causes the tests to fail. When trying to match the host, it is now including the base domain specified in the |
@dependabot recreate |
Bumps [django-hosts](https://github.com/jazzband/django-hosts) from 5.1 to 6.0. - [Changelog](https://github.com/jazzband/django-hosts/blob/master/docs/changelog.rst) - [Commits](jazzband/django-hosts@5.1...6.0) --- updated-dependencies: - dependency-name: django-hosts dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
09b577a
to
9b712fb
Compare
We have to fix these 3 test failures: ======================================================================
FAIL: test_docs_host_excluded (djangoproject.tests.ExcludeHostsLocaleMiddlewareTests.test_docs_host_excluded)
We get no Content-Language or Vary headers when docs host is excluded
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/djangoproject.com/djangoproject.com/djangoproject/tests.py", line 68, in test_docs_host_excluded
self.assertEqual(resp.status_code, HTTPStatus.FOUND)
AssertionError: 200 != <HTTPStatus.FOUND: 302>
======================================================================
FAIL: test_docs_host_forwarded_excluded (djangoproject.tests.ExcludeHostsLocaleMiddlewareTests.test_docs_host_forwarded_excluded)
We get no Content-Language or Vary headers when docs host
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/djangoproject.com/djangoproject.com/djangoproject/tests.py", line 92, in test_docs_host_forwarded_excluded
self.assertEqual(resp.status_code, HTTPStatus.FOUND)
AssertionError: 200 != <HTTPStatus.FOUND: 302>
======================================================================
FAIL: test_docs_host_not_excluded (djangoproject.tests.ExcludeHostsLocaleMiddlewareTests.test_docs_host_not_excluded)
We still get Content-Language when docs host is not excluded
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/djangoproject.com/djangoproject.com/djangoproject/tests.py", line 100, in test_docs_host_not_excluded
self.assertEqual(resp.status_code, HTTPStatus.FOUND)
AssertionError: 200 != <HTTPStatus.FOUND: 302>
----------------------------------------------------------------------
Ran 191 tests in 7.728s
FAILED (failures=3) |
Thanks, that's a starting point.
I tagged maintainers because this PR as been created by dependabot (not from me) and maybe someone can take care of it. |
Bumps django-hosts from 5.1 to 6.0.
Changelog
Sourced from django-hosts's changelog.
Commits
17fc0b6
Add release date for 6.0 (#165)57c16c5
Add note to FAQ in docs (#162)6b6d0a4
Confirmed support for Python 3.12 (#164)6519d3b
Dropped Python 3.7 (#164)4d4ef69
Run django main tests on Python >= 3.10 (#157)03331a4
Prepared release 5.2 (#154)30670e8
Replaced whitelist_externals with allowlist_externals in tox config5ba372d
Add missed changelog591bf5d
Fix erroneous empty pattern matching when PARENT_HOST is defined (#128)f7a9a60
Dropped support for Python 3.6You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)