Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-hosts from 5.1 to 6.0 in /requirements #1598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps django-hosts from 5.1 to 6.0.

Changelog

Sourced from django-hosts's changelog.

6.0 (2023-10-27)

  • BACKWARD-INCOMPATIBLE Dropped support for Python 3.7.

  • Confirmed support for Python 3.12.

5.2 (2023-01-12)

  • Fixed erroneous empty pattern matching when PARENT_HOST is defined.

  • Confirmed support for Django 4.1 (no code changes were required).

  • Confirmed support for Python 3.11 (no code changes were required).

  • BACKWARD-INCOMPATIBLE Dropped support for Python 3.6.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 29, 2024
@bmispelon
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/requirements/django-hosts-6.0 branch from 1308231 to 09b577a Compare August 23, 2024 20:45
@t-payne
Copy link
Contributor

t-payne commented Sep 28, 2024

This commit in django-hosts includes the change that causes the tests to fail. When trying to match the host, it is now including the base domain specified in the PARENT_HOST setting. It appears this causes the failing tests to not correctly match the docs host, so it then falls back to the default host, which is www. The homepage view (defined in the www urls) will then respond with a 200, rather than the expected 302 from the docs homepage view.

@pauloxnet
Copy link
Member

@dependabot recreate

Bumps [django-hosts](https://github.com/jazzband/django-hosts) from 5.1 to 6.0.
- [Changelog](https://github.com/jazzband/django-hosts/blob/master/docs/changelog.rst)
- [Commits](jazzband/django-hosts@5.1...6.0)

---
updated-dependencies:
- dependency-name: django-hosts
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/requirements/django-hosts-6.0 branch from 09b577a to 9b712fb Compare October 31, 2024 00:58
@pauloxnet
Copy link
Member

We have to fix these 3 test failures:

   ======================================================================
  FAIL: test_docs_host_excluded (djangoproject.tests.ExcludeHostsLocaleMiddlewareTests.test_docs_host_excluded)
  We get no Content-Language or Vary headers when docs host is excluded
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/djangoproject.com/djangoproject.com/djangoproject/tests.py", line 68, in test_docs_host_excluded
      self.assertEqual(resp.status_code, HTTPStatus.FOUND)
  AssertionError: 200 != <HTTPStatus.FOUND: 302>
  
  ======================================================================
  FAIL: test_docs_host_forwarded_excluded (djangoproject.tests.ExcludeHostsLocaleMiddlewareTests.test_docs_host_forwarded_excluded)
  We get no Content-Language or Vary headers when docs host
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/djangoproject.com/djangoproject.com/djangoproject/tests.py", line 92, in test_docs_host_forwarded_excluded
      self.assertEqual(resp.status_code, HTTPStatus.FOUND)
  AssertionError: 200 != <HTTPStatus.FOUND: 302>
  
  ======================================================================
  FAIL: test_docs_host_not_excluded (djangoproject.tests.ExcludeHostsLocaleMiddlewareTests.test_docs_host_not_excluded)
  We still get Content-Language when docs host is not excluded
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/djangoproject.com/djangoproject.com/djangoproject/tests.py", line 100, in test_docs_host_not_excluded
      self.assertEqual(resp.status_code, HTTPStatus.FOUND)
  AssertionError: 200 != <HTTPStatus.FOUND: 302>
  
  ----------------------------------------------------------------------
  Ran 191 tests in 7.728s
  
  FAILED (failures=3)

@pauloxnet pauloxnet requested a review from a team October 31, 2024 09:31
@pauloxnet pauloxnet added bug help-needed Help needed labels Oct 31, 2024
@bmispelon
Copy link
Member

bmispelon commented Oct 31, 2024

@t-payne and me looked into this at the DjangoCon US sprints and we couldn't really figure it out.

I think it might be a genuine issue, possibly relating to #1590

In any case, I would wait until the tests are passing before asking for a review.

@bmispelon bmispelon removed the request for review from a team October 31, 2024 13:34
@pauloxnet
Copy link
Member

@t-payne and me looked into this at the DjangoCon US sprints and we couldn't really figure it out.
I think it might be a genuine issue, possibly relating to #1590

Thanks, that's a starting point.

In any case, I would wait until the tests are passing before asking for a review.

I tagged maintainers because this PR as been created by dependabot (not from me) and maybe someone can take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file help-needed Help needed python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants