Add local Django community page #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve the conflicts |
datur
force-pushed
the
add-local-django-community-page
branch
from
1478bb6 to
7bc0b7b
Compare
Conflicts resolved now 😄 |
|
Do we need an additional package and SVG from Material icons to add this feature to the website? |
@pauloxnet I don't think so according what I've seen on the changes, I'll review the PR to double check |
camilonova
approved these changes
Sep 27, 2023
This django package provides the equivalent of a choice field containing a list of all the countries in the world. This will be used when adding a Local Django Community to the new section of the community page.
This model facilitates the listing of local django communities from around the world. This will be listed on a page within the community section of the website.
This change adds the local django communities page to the communities section of djangoproject.com
for more information, see https://pre-commit.ci
sabderemane
force-pushed
the
add-local-django-community-page
branch
from
7bc0b7b to
4aa4c97
Compare
for more information, see https://pre-commit.ci
sabderemane
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
Sorry for the late review. Thank you @datur for your contribution 🚀
I've made some small changes to improve accessibility and added the case of if there's no data.
Welcome on board ⛵
sabderemane
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1239
This change adds a new Local Django Communities page to the community area of the website. The aim is to list Local Django Communities around the world.
Community Page:
Local Django Community page:
