Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no_municipalities.py to reflect recent changes to norwegian counties #509

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hakosl
Copy link

@hakosl hakosl commented Jun 17, 2024

Update list of Norwegian counties(fylker) according to changes at the start of 2024: https://en.wikipedia.org/wiki/Counties_of_Norway#List_of_counties

docs/changelog.rst Outdated Show resolved Hide resolved
@hakosl
Copy link
Author

hakosl commented Jun 26, 2024

I fixed the tests

@benkonrath
Copy link
Member

As a follow up to Claude's comment about the changelog, maybe we should use the same procedure as we did with the 3.1 release when we had breaking data changes.

  1. Add a warning to NOMunicipalitySelect.
import warnings

class NOMunicipalitySelect(Select):
    def __init__(self, attrs=None):
        warnings.warn("Choices have changed for NOMunicipalitySelect in localflavor 4.1. See changelog for details.")
        super().__init__(attrs, choices=MUNICIPALITY_CHOICES)
  1. Be very clear about the breaking change at the start of the changelog and provide instructions. The 3.1 release notes are a good example:

https://github.com/django/django-localflavor/blob/master/docs/changelog.rst#31---2021-05-28

@hakosl What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants