Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Indonesian localflavour #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

geomars
Copy link

@geomars geomars commented Oct 8, 2018

Modification:

  • Update PROVINCE_CHOICES in localflavor/id_/id_choices.py to comply with official codes issued by Indonesian internal affair ministry
  • Update test/test_id.py

@claudep
Copy link
Member

claudep commented Oct 8, 2018

Thanks, much better now! @benkonrath will probably review it in due time. But I don't think this will be accepted as is, because this would break existing usage for people having stored previous values in their models. I'm sure Ben will be able to help with coping with this sort of changes.

@codecov-io
Copy link

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files         157      157           
  Lines        3981     3981           
  Branches      523      523           
=======================================
  Hits         3819     3819           
  Misses         98       98           
  Partials       64       64
Impacted Files Coverage Δ
localflavor/id_/id_choices.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78df3b...4d17e58. Read the comment docs.

@geomars
Copy link
Author

geomars commented Oct 8, 2018

Thanks for your review @claudep

@benkonrath
Copy link
Member

@geomars Thanks for this pull request and sorry for the delay in responding. Could you provide some background on why you want to change the codes that are stored for the provinces? Is it because the current codes aren't meaningful?

Instead of changing the current version of PROVINCE_CHOICES, I think it's better to make a new version with a different name. You would also need to create new version of IDProvinceSelect that uses the new version of PROVINCE_CHOICES. Doing this will allow us to depreciate the current versions, highlight this deprecation in the changelog and eventually remove the field and the choices.

#: http://id.wikipedia.org/wiki/Daftar_provinsi_Indonesia
# Provincial code in Indonesia doesn't comply with the standard 3-letter province code
# data taken from the official page of Indonesian internal affair ministry
# http://www.kemendagri.go.id/pages/data-wilayah
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a 404 page not found error when I try to load this URL. Has this page been removed since you made this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants