Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include information about Windows usage and Python/DB versions in README #45

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anorthall
Copy link

There has been at least two instances of confusion about the need to modify versions before running, so I thought I'd clarify it in README.md.

Copy link

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

`export DJANGO_PATH=~/projects/django/`

If you see a docker-compose warning about it not being defined followed by an error ensure that is defined in the shell you are using.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because I tested the error and it is extremely specific and could not be confused - not necessary to have here.

@anorthall anorthall changed the title Clarify need to specify appropriate versions in quick start guide Include information about Windows usage and Python/DB versions in README Dec 11, 2023
@ngnpope
Copy link
Member

ngnpope commented Dec 19, 2024

I've just opened #48 which addresses a whole host of issues. In there I've removed the ${PWD} - I'm not honestly sure why it was added. It also makes the default for DJANGO_PATH equal to ./django which removes another thing that needs to be configured (as long as the django and django-docker-box repositories are cloned adjacent to each other).

Ideally I'd like to avoid adding a bunch of special instructions for different platforms if we can avoid it. Maybe instead of having to define DOCKER_DEFAULT_PLATFORM=linux/amd64 we could add platform: linux/amd64 in compose.yml and/or --platform=linux/amd64 to FROM in the Containerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants