Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL benchmarks for path URLs #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion benchmarks/url_benchmarks/url_resolve/benchmark.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.urls import resolve
from django.urls import resolve, Resolver404

from ...utils import bench_setup

Expand All @@ -12,3 +12,15 @@ def time_resolve(self):
resolve("/url-resolve/basic/")
resolve("/url-resolve/fallthroughview/")
resolve("/url-resolve/replace/1")

def time_resolve_path(self):
resolve("/url-resolve/num/1/")

def time_resolve_literal_path(self):
resolve("/url-resolve/basic-path/")

def time_resolve_unknown(self):
try:
resolve("/unknown/")
except Resolver404:
pass
4 changes: 3 additions & 1 deletion benchmarks/url_benchmarks/url_resolve/urls.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.urls import re_path
from django.urls import path, re_path

from . import views

Expand All @@ -13,3 +13,5 @@ def generate_filler_patterns(num=1):
urlpatterns.append(re_path(r"^basic/$", views.basic, name="basic"))
urlpatterns.append(re_path(r"^[a-z]*/$", views.catchall, name="catchall"))
urlpatterns.append(re_path(r"^replace/(?P<var>.*?)", views.vars, name="vars"))
urlpatterns.append(path("num/<int:var>/", views.vars, name="num"))
urlpatterns.append(path("basic-path/", views.vars, name="basic-path"))
7 changes: 7 additions & 0 deletions benchmarks/url_benchmarks/url_reverse/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,10 @@ def time_reverse(self):
reverse("url_reverse:catchall")
reverse("url_reverse:vars", args=[1])
reverse("url_reverse:vars", kwargs={"var": 1})

def time_reverse_path(self):
reverse("url_reverse:num", args=[1])
reverse("url_reverse:num", kwargs={"var": 1})

def time_reverse_literal_path(self):
reverse("url_reverse:basic-path")
4 changes: 3 additions & 1 deletion benchmarks/url_benchmarks/url_reverse/urls.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.urls import re_path
from django.urls import path, re_path

from . import views

Expand All @@ -15,3 +15,5 @@ def generate_filler_patterns(num=1):
urlpatterns.append(re_path(r"^basic/$", views.basic, name="basic"))
urlpatterns.append(re_path(r"^[a-z]*/$", views.catchall, name="catchall"))
urlpatterns.append(re_path(r"^replace/(?P<var>.*?)", views.vars, name="vars"))
urlpatterns.append(path("num/<int:var>/", views.vars, name="num"))
urlpatterns.append(path("basic-path/", views.vars, name="basic-path"))