Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.3.0 Release. #260

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Version 3.3.0 Release. #260

merged 3 commits into from
Jul 1, 2021

Conversation

carltongibson
Copy link
Member

@carltongibson carltongibson commented Jul 1, 2021

Hi @acu192 @qeternity

reparing the 3.3. release.

Thus far just:

  • Updated Readme to mention PubSub layer.

Did either of have thoughts on additional content/warnings/etc? (ASGI is explicitly At most once delivery. I'm not sure how much we need to labour that. If folks need guaranteed delivery going to need to program for it... Thoughts? 🤔)

@qeternity
Copy link
Contributor

qeternity commented Jul 1, 2021

Howdy @carltongibson - yes I think the pubsub layer just needs to have some clarification around the current differences in behavior from the core layer. The two that come to mind are:

  1. anyone sensitive to redis interruptions and subsequent missed messages needs to implement the consumer notifications (and as we've discussed, even here the end-to-end guarantees are relatively weak)
  2. the current event loop handling is not as forgiving as the core layer, so certain integrations (i.e. Celery) will not be drop-in replacements until we can improve that

And a massive thanks to @acu192 for contributing and putting some momentum behind this project!

@carltongibson
Copy link
Member Author

Change notes are for that last item. 😀

@carltongibson carltongibson requested review from andrewgodwin and acu192 and removed request for andrewgodwin July 1, 2021 13:09
@carltongibson
Copy link
Member Author

@qeternity I added change notes in 9b103a5. I think they more of less cover it.

I think the README could probably do with a restructure — separating the options for the separate channel layers, but I think better to release and work on that.

@carltongibson
Copy link
Member Author

OK, bumped version.

Unless you, @qeternity and @acu192, have input, I'll tag and release later on.

Thanks both for the great additions here.

@carltongibson carltongibson changed the title Updated Readme to mention PubSub layer. Version 3.3.0 Release. Jul 1, 2021
@carltongibson carltongibson merged commit 9793d09 into main Jul 1, 2021
@carltongibson carltongibson deleted the 3.3-release branch July 1, 2021 14:40
@carltongibson carltongibson removed the request for review from acu192 July 1, 2021 14:41
@acu192
Copy link
Collaborator

acu192 commented Jul 1, 2021

Thanks @carltongibson for prepping this release. Exciting stuff!

I think the README could probably do with a restructure — separating the options for the separate channel layers, but I think better to release and work on that.

Agreed, we can tackle that for next release, perhaps.

@carltongibson
Copy link
Member Author

Opened #261 to track that.

Doesn't have to wait for a release. It can just be merged in any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants