Sending Single Message Per Client Prefix/ User Prefix

[gekco]

previously for each channel subscribed to a group message was being pushed to list stored at channel key. I have grouped those messages by sending list of channels associated with that that channel redis key with a single message . It saves a great deal of time by reducing the number of push and pops from redis.
Fixes : #7, #83

[andrewgodwin]

I'm still not entirely clear what this is doing - the code is quite hard to read. Could you add some comments and make it very clear what's happening?

[andrewgodwin]

Why did you indent this without changing it?

[gekco]

i guess the IDE did it. i will revert it.

[andrewgodwin]

This block needs some serious comments to say what's happening - I'm finding it hard to read.

[gekco]

on it

[gekco]

(Correct me if i am understanding this wrong)
say there is a group name 'Group-A' with 100 members(channels)

originally when i called group_send('Group-A', message_dictionary)
the same message was being pushed 100 times each time with a different asgi_channel value to the same redis queue(because multiple channels MAY have same redis key) which was being popped at function receive_single 100 times obviously and the message was getting processed for a single channel.

Modifications:
what i did was coalesce those messages i.e. for those 100 channels i will be sending a single message per unique redis key K for all the channels that are mapped to K, by sending a comma separated string of those channels instead of a single channel in asgi_channel.

On the receiving end i just process the message for all of the channels that are received in the message in a for loop. This Largely reduces the time to push group messages onto channel redis layer and the number of pops.
For Example if all the 100 channels have the same channel key there will be a single message for all the 100 channels which will be pushed on the redis queue at channel key and popped from the same.

[gekco]

previously channel_redis_keys would contain duplicate keys as multiple channels may map to same redis key. hence the more number of pushes.

[andrewgodwin]

OK, I mostly understand it now, but a couple of things I'd like to see changed:

• The _map_channel_to_connection function is now far too complex - that whole thing should be refactored so it doesn't have to pass around things as dicts of lists and so forth. Maybe flatten it more into the only place it's called.

• I'm not particularly happy with the comma-separated approach to the storing of channel names. Maybe just use a native msgpack list?

[gekco]

1. I have restructured my code a bit , also using a more relevant function name, eliminated some repitive code, flattened it, have a look. i am now using _map_channel_keys_to_connection function.
2. I am using a msgpack native list now

[andrewgodwin]

Thanks!

[gekco]

@andrewgodwin Thank you so much. This was my first PR to get merged . Yayy. :D