Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add giovannicimolin to django-commons #135

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add giovannicimolin to django-commons #135

merged 2 commits into from
Dec 17, 2024

Conversation

cunla
Copy link
Member

@cunla cunla commented Dec 14, 2024

Fix #134

Copy link

github-actions bot commented Dec 14, 2024

Terraform plan in terraform
With var files: terraform/production/org.tfvars terraform/production/repositories.tfvars
With variables: github_token = (sensitive value)

Plan: 1 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place

Terraform will perform the following actions:

  # github_membership.this["giovannicimolin"] will be created
+   resource "github_membership" "this" {
+       downgrade_on_destroy = false
+       etag                 = (known after apply)
+       id                   = (known after apply)
+       role                 = "member"
+       username             = "giovannicimolin"
    }

  # github_team_members.repo_team_members["django-fsm-2"] will be updated in-place
!~  resource "github_team_members" "repo_team_members" {
        id      = "django-fsm-2"
#        (1 unchanged attribute hidden)

+       members {
+           role     = "member"
+           username = "giovannicimolin"
        }

#        (2 unchanged blocks hidden)
    }

Plan: 1 to add, 1 to change, 0 to destroy.

📝 Plan generated in Plan org changes and list them in a PR #58

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should be added as a member to Django-fsm2 so they have triage permissions

Files changed:
M	terraform/production/repositories.tfvars
@Stormheg
Copy link
Member

@cunla I added them as a member of django-fsm-2. Will this apply work? Or will this cause issues similar to #92 if they haven't accepted the invitation to join yet.

@cunla
Copy link
Member Author

cunla commented Dec 15, 2024

I think it is better adding them first to the org and only after confirming they are in the org adding them to various teams.

@tim-schilling
Copy link
Member

The issue in #92 was a different case since the person didn't join ahead of time. Here the person is joining. Presumably, they'll accept the invitation promptly.

@cunla if your concern isn't technical, can you please expand on it for me?

@cunla
Copy link
Member Author

cunla commented Dec 15, 2024

The issue in #92 was a different case since the person didn't join ahead of time. Here the person is joining. Presumably, they'll accept the invitation promptly.

@cunla if your concern isn't technical, can you please expand on it for me?

It is technical. I am not sure whether adding a non-org member to an org-team is possible.
Since the apply would only invite to the org and not directly add, the adding to the team part might fail.

@tim-schilling tim-schilling merged commit d7d70bd into main Dec 17, 2024
2 checks passed
@tim-schilling tim-schilling deleted the add-user/134 branch December 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✋ [MEMBER] - giovannicimolin
5 participants