-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add giovannicimolin to django-commons #135
Conversation
Terraform plan in terraform Plan: 1 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
!~ update in-place
Terraform will perform the following actions:
# github_membership.this["giovannicimolin"] will be created
+ resource "github_membership" "this" {
+ downgrade_on_destroy = false
+ etag = (known after apply)
+ id = (known after apply)
+ role = "member"
+ username = "giovannicimolin"
}
# github_team_members.repo_team_members["django-fsm-2"] will be updated in-place
!~ resource "github_team_members" "repo_team_members" {
id = "django-fsm-2"
# (1 unchanged attribute hidden)
+ members {
+ role = "member"
+ username = "giovannicimolin"
}
# (2 unchanged blocks hidden)
}
Plan: 1 to add, 1 to change, 0 to destroy. 📝 Plan generated in Plan org changes and list them in a PR #58 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they should be added as a member to Django-fsm2 so they have triage permissions
Files changed: M terraform/production/repositories.tfvars
590ee5e
to
9bed634
Compare
I think it is better adding them first to the org and only after confirming they are in the org adding them to various teams. |
It is technical. I am not sure whether adding a non-org member to an org-team is possible. |
Fix #134