-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modify language menu for pages only if it is present #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 72 72
Lines 2536 2536
Branches 358 358
=======================================
Hits 2306 2306
Misses 170 170
Partials 60 60
|
marksweb
requested changes
May 22, 2023
Co-authored-by: Mark Walker <[email protected]>
I'll install and test this in the morning 👍 |
marksweb
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok checked this change with page editing and all seems well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pages do not need to have language menus (even if
USE_I18N
isTrue
). Trying to modify a non-existing menu leads to an attribute error.This PR also runs
makemessages
and includes updated.mo
files.Finally, the
locale
path is included in the manifest for future packaging.Steps to reproduce
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.