Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify language menu for pages only if it is present #333

Merged
merged 5 commits into from
May 23, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented May 16, 2023

Description

Pages do not need to have language menus (even if USE_I18N is True). Trying to modify a non-existing menu leads to an attribute error.

This PR also runs makemessages and includes updated .mo files.

Finally, the locale path is included in the manifest for future packaging.

Steps to reproduce

  • Create a project with a single page
  • Try previewing any page

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from marksweb May 16, 2023 16:35
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #333 (f1d6737) into master (91eafe1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          72       72           
  Lines        2536     2536           
  Branches      358      358           
=======================================
  Hits         2306     2306           
  Misses        170      170           
  Partials       60       60           
Impacted Files Coverage Δ
djangocms_versioning/cms_toolbars.py 96.90% <100.00%> (ø)

@fsbraun fsbraun mentioned this pull request May 22, 2023
tests/test_toolbars.py Show resolved Hide resolved
@marksweb
Copy link
Member

I'll install and test this in the morning 👍

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok checked this change with page editing and all seems well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants