Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Restore "In Collection" button in the toolbar #286

Merged

Conversation

joshyu
Copy link
Contributor

@joshyu joshyu commented Nov 6, 2024

Description

fix #285

Checklist

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (79aaae4) to head (ded564a).
Report is 67 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   84.19%   79.21%   -4.98%     
==========================================
  Files          23       40      +17     
  Lines        1740     1862     +122     
  Branches      282      212      -70     
==========================================
+ Hits         1465     1475      +10     
- Misses        245      355     +110     
- Partials       30       32       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏🎉

@marksweb marksweb merged commit 6589f66 into django-cms:master Nov 6, 2024
14 of 15 checks passed
@joshyu joshyu deleted the fix/restore-toolbar-in-collection-button branch November 6, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "In Collection" button is missing in the toolbar
2 participants