added multiselect and add items to collection in admin

[vipulnarang95]

Description

Feature added:
Add items to collection action added for all moderated models in cms_config

Related resources

• #...
• #...

Checklist

• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines

[vipulnarang95]

@fsbraun Please check and review

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (79aaae4) to head (9318fc5).
Report is 58 commits behind head on master.

Files	Patch %	Lines
djangocms_moderation/cms_config.py	90.00%	0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (79aaae4) and HEAD (9318fc5). Click for more details.

HEAD has 2 uploads less than BASE

| Flag | BASE (79aaae4) | HEAD (9318fc5) | |------|------|------| ||12|10|

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   84.19%   79.05%   -5.15%     
==========================================
  Files          23       40      +17     
  Lines        1740     1862     +122     
  Branches      282      260      -22     
==========================================
+ Hits         1465     1472       +7     
- Misses        245      359     +114     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fsbraun]

Looks good. Can you add some tests? What happens if there are published, unpublished or archived objects selected when the action is run?

[fsbraun]

Actually, this is a nice example of the power of cms_config.

[vipulnarang95]

@fsbraun Tests are already there: https://github.com/django-cms/djangocms-moderation/blob/master/tests/test_forms.py#L146
Do you want me to add some specific?

[fsbraun]

Test adding a mixture of objects with different version states. I would expect a user message that some items could not be added to the collection since they are not drafts, or are locked.

Also, the test should not use the form directly, but add_items_to_collection instead.

[vipulnarang95]

Hi @fsbraun , I was trying adding test cases accordingly but after writing initial test cases and debugging, found that add_items_to_collection only checks if version_ids are available it will return a redirect url to moderation screen.
https://github.com/django-cms/djangocms-moderation/blob/master/djangocms_moderation/admin_actions.py#L143
The else section only gets called when nothing is selected.
Can you please check once?

[vipulnarang95]

Hi @fsbraun can you also check my comment above?

[fsbraun]

@vipulnarang95 Yes, it seems add_items_to_collection redirects to this view:

djangocms-moderation/djangocms_moderation/views.py

Line 31 in e2e8ac2

class CollectionItemsView(FormView):

. So, it'll be great if we could test if this view reacts if you tried to add, say, an already published object to the moderation request. (Or, maybe, that's already done somewhere else?)

[vipulnarang95]

@fsbraun Agreed but this redirects to the moderation view by just checking the versions and there is no logic in the code to check if the versions are draft/published.
It just checks if there is version of the content model or not.
Also this view is already been tested in test_views.py

[fsbraun]

I'm not sure if I understand. Are you saying that you can add published versions to a moderation request? Does that make sense? I'd expect to get an error message if I tried to do this.

I now looked at the code and see that the CollectionItemForm does just drop unsutable versions (like published versions) from the selection. (And that's covered by tests.)

[vipulnarang95]

I'm not sure if I understand. Are you saying that you can add published versions to a moderation request? Does that make sense? I'd expect to get an error message if I tried to do this.
No this gets dropped from the collection as this doesn't makes any sense..
I now looked at the code and see that the CollectionItemForm does just drop unsutable versions (like published versions) from the selection. (And that's covered by tests.)
Yes that is covered which I was saying

[vipulnarang95]

Also @fsbraun can you also give me the access to release these addons?