feat: Check for link configuration

django-cms · Nov 20, 2024 · 5776cd1 · 5776cd1
1 parent b6f1470
commit 5776cd1
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 28 deletions.
diff --git a/djangocms_frontend/apps.py b/djangocms_frontend/apps.py
@@ -10,6 +10,7 @@ def ready(self):
         from . import plugin_tag
 
         checks.register(check_settings)
+        checks.register(check_installed_apps)
         plugin_tag.setup()
 
 
@@ -19,21 +20,51 @@ def check_settings(*args, **kwargs):
     warnings = []
 
     if hasattr(settings, "DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH"):  # pragma: no cover
-        warnings.append(checks.Warning(
-            "The DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH setting was removed in djangocms-frontend 2.\n"
-            "Use DJANGOCMS_LINK_MINIMUM_INPUT_LENGTH instead.",
-            "This message disappears after removing the DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH from your project's "
-            "settings.\n",
-            id="djangocms_frontend.W001",
-            obj="settings.DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH",
-        ))
+        warnings.append(
+            checks.Warning(
+                "The DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH setting was removed in djangocms-frontend 2.\n"
+                "Use DJANGOCMS_LINK_MINIMUM_INPUT_LENGTH instead.",
+                "This message disappears after removing the DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH from "
+                "your project's settings.\n",
+                id="djangocms_frontend.W001",
+                obj="settings.DJANGOCMS_FRONTEND_MINIMUM_INPUT_LENGTH",
+            )
+        )
     if hasattr(settings, "DJANGOCMS_FRONTEND_LINK_MODELS"):  # pragma: no cover
-        warnings.append(checks.Warning(
-            "The DJANGOCMS_FRONTEND_LINK_MODELS setting was removed in djangocms-frontend 2.\n"
-            "djangocms-frontend 2 uses linkable models from djangocms-link. See "
-            "https://github.com/django-cms/djangocms-link#django-cms-link for more info.",
-            "This message disappears after removing the DJANGOCMS_FRONTEND_LINK_MODELS from your project's settings.\n",
-            id="djangocms_frontend.W002",
-            obj="settings.DJANGOCMS_FRONTEND_LINK_MODELS",
-        ))
+        warnings.append(
+            checks.Warning(
+                "The DJANGOCMS_FRONTEND_LINK_MODELS setting was removed in djangocms-frontend 2.\n"
+                "djangocms-frontend 2 uses linkable models from djangocms-link. See "
+                "https://github.com/django-cms/djangocms-link#django-cms-link for more info.",
+                "This message disappears after removing the DJANGOCMS_FRONTEND_LINK_MODELS from your "
+                "project's settings.\n",
+                id="djangocms_frontend.W002",
+                obj="settings.DJANGOCMS_FRONTEND_LINK_MODELS",
+            )
+        )
     return warnings
+
+
+def check_installed_apps(app_configs, **kwargs):
+    from django.conf import settings
+
+    errors = []
+    link_contrib_apps = [
+        "djangocms_frontend.contrib.carousel",
+        "djangocms_frontend.contrib.image",
+        "djangocms_frontend.contrib.link",
+    ]
+
+    if any(app in settings.INSTALLED_APPS for app in link_contrib_apps):
+        if "djangocms_link" not in settings.INSTALLED_APPS:  # pragma: no cover
+            errors.append(
+                checks.Error(
+                    "djangocms-frontend requires djangocms-link to be installed for the following plugins: {}.\n"
+                    "Add 'djangocms_link' to your INSTALLED_APPS setting or remove all of the above apps.".format(
+                        ", ".join(link_contrib_apps)
+                    ),
+                    id="djangocms_frontend.E001",
+                    obj="settings.INSTALLED_APPS",
+                )
+            )
+    return errors
diff --git a/djangocms_frontend/static/djangocms_frontend/css/base.css b/djangocms_frontend/static/djangocms_frontend/css/base.css
diff --git a/private/sass/components/_tabs.scss b/private/sass/components/_tabs.scss
@@ -4,7 +4,7 @@
 }
 
 ul.nav {
-    &:has(> li ~ div) {
+    &:not(:has(> li:nth-child(2))) {
         // Hide single tab
         display: none;
     }

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,14 +1,14 @@
 [tool.black]
-exclude = [
-  ".git",
-  ".hg",
-  ".tox",
-  "venv",
-  ".venv",
-  "_build",
-  "build",
-  "dist",
-]
+exclude = '''
+  .git
+  .hg
+  .tox
+  venv
+  .venv
+  _build
+  build
+  dist
+'''
 
 [tool.ruff]
 line-length = 119