Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove newline from alias template #220

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Fix: Remove newline from alias template #220

merged 4 commits into from
Feb 12, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Feb 12, 2024 •
edited
Loading

Also tries to fix #221

@fsbraun fsbraun requested a review from marksweb February 12, 2024 10:16
marksweb
marksweb approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this suggests that it just ends all files that way.

@fsbraun fsbraun merged commit 57d08ea into django-cms:master Feb 12, 2024
12 checks passed
@fsbraun
Copy link
Member Author

fsbraun commented Feb 12, 2024

Indeed! I did two PR and the bot just undid my changes with its own commit - until I noticed. Pretty creepy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-commit bot breaks tests
2 participants
@fsbraun @marksweb