Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added compatibility code in aldryn_config go support setting THUMBNAIL_DEFAULT_STORAGE in django 4.2 #1440

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

kinkerl
Copy link
Contributor

@kinkerl kinkerl commented Nov 17, 2023

Description

This change adds compatibility to django 4.2 and the new way storages and handled.

Related resources

https://docs.djangoproject.com/en/4.2/releases/4.2/#custom-file-storages

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41b969d) 76.59% compared to head (8b569c2) 76.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   76.59%   76.59%           
=======================================
  Files          75       75           
  Lines        3546     3546           
  Branches      568      568           
=======================================
  Hits         2716     2716           
  Misses        667      667           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksweb marksweb merged commit 032c595 into django-cms:master Nov 17, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants