-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: French translations, prevention of opening SVG directly in browser through canonical url #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix/expand-image
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
=======================================
Coverage 76.43% 76.43%
=======================================
Files 75 75
Lines 3514 3514
Branches 562 562
=======================================
Hits 2686 2686
Misses 666 666
Partials 162 162 ☔ View full report in Codecov by Sentry. |
fsbraun
changed the title
feat:;
feat: French translations, prevention of opening SVG directly in browser through canonical url
Oct 2, 2023
fsbraun
commented
Oct 2, 2023
vinitkumar
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get this merged and released 🚢 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds French translations to Django Filer 3.1.
Adds another security improvement: Right click on "Canonical URL" action and "Open in new tab" now displays SVG not directly in the browser but using an
<img>
tag for security reasons.Adds Zoom functionality to svg preview.
Related resources
<img>
tags to avoid js attacks #1429Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.