Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: French translations, prevention of opening SVG directly in browser through canonical url #1430

Merged
merged 30 commits into from
Oct 2, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 2, 2023

Description

  • Adds French translations to Django Filer 3.1.

  • Adds another security improvement: Right click on "Canonical URL" action and "Open in new tab" now displays SVG not directly in the browser but using an <img> tag for security reasons.

  • Adds Zoom functionality to svg preview.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (421c86b) 76.43% compared to head (01a4f39) 76.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files          75       75           
  Lines        3514     3514           
  Branches      562      562           
=======================================
  Hits         2686     2686           
  Misses        666      666           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from vinitkumar October 2, 2023 07:53
@fsbraun fsbraun changed the title feat:; feat: French translations, prevention of opening SVG directly in browser through canonical url Oct 2, 2023
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit c9872d8 into django-cms:master Oct 2, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants