Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Mastic clean up #1200

Open
wants to merge 5 commits into
base: cjpatton/947-14-truncated-weights
Choose a base branch
from

Conversation

cjpatton
Copy link
Collaborator

@cjpatton cjpatton commented Jan 13, 2025

Stacked on #1199.

Miscellaneous, somewhat opinionated clean up after completing Mastic.

  • xof: Have seed_stream() take an array
  • mastic: Define constants for nonce and seed sizes
  • mastic: Remove bits field from Mastic struct
  • Move szk module from flp to vdaf::mastic
  • mastic: Update draft reference

@cjpatton cjpatton changed the title Clean up after Mastic More Mastic clean up Jan 13, 2025
Some of the implementation details of SZK are, for the moment, specific
to Mastic. For example, the domain separation tag for each XOF
invocation is prefixed by `b"mastic"`. It therefore makes sense to move
this module to `mastic` until such time we need to refactor in order to
use SZK in multiple places.
@cjpatton cjpatton force-pushed the cjpatton/947-15-cleanup branch from 1810f3a to 20bc920 Compare January 13, 2025 21:10
@cjpatton cjpatton marked this pull request as ready for review January 13, 2025 21:18
@cjpatton cjpatton requested a review from a team as a code owner January 13, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant