Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mouse cursor hiding when idle #225

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

knuton
Copy link
Member

@knuton knuton commented Feb 12, 2025

This lets the mouse cursor be initially hidden, appear when moved, and hidden again after 10 seconds of being idle.

The timing is chosen so that the cursor is normally hidden, but stays visible for relatively long period should someone attach and use a mouse.

We have been hiding idle cursors in the Play web app, but have found that the mouse needs to be moved once upon boot for the web app's logic to work, which leaves the cursor permanently visible in mouse free use. This seems to be a system/engine level issue, that we can not control from the web app. By moving mouse hiding to the OS we can also remove the complexity and event handling overhead from the web runtime.

Checklist

  • Changelog updated
  • Code documented
  • User manual updated

This lets the mouse cursor be initially hidden, appear when moved, and
hidden again after 10 seconds of being idle.

The timing is chosen so that the cursor is normally hidden, but stays
visible for relatively long period should someone attach and use a
mouse.

We have been hiding idle cursors in the Play web app, but have found
that the mouse needs to be moved once upon boot for the web app's logic
to work, which leaves the cursor permanently visible in mouse free use.
This seems to be a system/engine level issue, that we can not control
from the web app. By moving mouse hiding to the OS we can also remove
the complexity and event handling overhead from the web runtime.
@knuton knuton added the reviewable Ready for initial or iterative review label Feb 12, 2025
@knuton knuton requested a review from guyonvarch February 12, 2025 05:40
@guyonvarch
Copy link
Member

How does it work in addition with hiding the cursor in Play? I guess we should stop hiding the cursor in Play at some point?

@guyonvarch guyonvarch added details needed Further information requested to better evaluate changes and removed reviewable Ready for initial or iterative review labels Feb 19, 2025
@knuton
Copy link
Member Author

knuton commented Feb 19, 2025

How does it work in addition with hiding the cursor in Play? I guess we should stop hiding the cursor in Play at some point?

Yes, please check #2288 in the apps repo, there's a link to a queued task for removing the functionality in the future. I wouldn't remove it from Play before most installations run the updated PlayOS.

@knuton knuton added reviewable Ready for initial or iterative review and removed details needed Further information requested to better evaluate changes labels Feb 19, 2025
@guyonvarch
Copy link
Member

Looking good on a live USB system, on the lab, the mouse is initially not shown, and disappear 10 seconds of idleness after being moved. Opening Play, it hides after some seconds, then show again, then hide with unclutter. When moving the mouse, I can see it again.

@guyonvarch guyonvarch merged commit 2fff537 into dividat:main Feb 20, 2025
18 checks passed
@knuton knuton deleted the hide-mouse-cursor branch February 20, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewable Ready for initial or iterative review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants