Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to switch color theme #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ability to switch color theme #16

wants to merge 1 commit into from

Conversation

astavonin
Copy link

The submission introduces new flag theme. There are to possible values: dark (default value, current helloworld theme) and default (theme based on terminal settings).

@divan
Copy link
Owner

divan commented Mar 4, 2016

Hi Alex, thanks for PR and sorry for the response delay

I initially dumped themes' support in favor of only one cause it would require some efforts to make UI looks great with all themes (choosing default colors, mainly), and TermUI currently doesn't provide clear theme framework.
Taking into account there are only two themes available, I decided it's worth it at all.

Anyway, if there is a demand for it, I don't mind introducing support for themes in expvarmon, but adding new flag option doesn't look justified for me. I doubt this will be used a lot.

So, what do you think if we move configuration part into environment variable, say "EXPVARMON_THEME"?

@astavonin
Copy link
Author

Personally, I prefer to use key. It bit more flexible and explicit as you always knows your flags and able to change it easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants