Bugfix - remove source #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nofurtherinformation
temporarily deployed
to
pr-180
GitHub Actions
Inactive
nofurtherinformation
temporarily deployed
to
pr-180
GitHub Actions
Inactive
| ].forEach(layer => { | ||
| map.getLayer(layer) && map.removeLayer(layer); | ||
| }); | ||
|
|
||
| [BLOCK_SOURCE_ID].forEach(source => { |
There was a problem hiding this comment.
This is the actual bugfix, rest is just prettier
raphaellaude
previously approved these changes
Nov 14, 2024
nofurtherinformation
temporarily deployed
to
pr-180
GitHub Actions
Inactive
|
P.s. @raphaellaude added one small refactor, the fit to bounds was acting slightly buggy so I pulled that into the |
nofurtherinformation
temporarily deployed
to
pr-180
GitHub Actions
Inactive
raphaellaude
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in refactor that missed removing the maplibre source on remove layers. Current refactor is more readable for future changes.
Description
removeBlockLayersadds a second loop for sources that callsremoveSourceReviewers