-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced shattering #129
Enhanced shattering #129
Conversation
…d-shattering-rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good – two v small comments, only one blocking.
@@ -174,6 +175,33 @@ async def shatter_parent( | |||
return result | |||
|
|||
|
|||
@app.patch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H: Sorry forgot to mention this before but could you add a test for this function, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes 100%. Had this on my list todo but totally forgot!
app/src/app/constants/layers.ts
Outdated
'line-width': [ | ||
'case', | ||
['boolean', ['feature-state', 'focused'], false], | ||
10, // Width of 10 when focused | ||
['boolean', ['feature-state', 'highlighted'], false], | ||
10, // Width of 5 when highlighted | ||
0, // Default width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Round cap is a good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR works to enhance the shattering UX to support the use cases and detailed work on shattered geographies.
Description
The workflow this aims to accomplish is:
WIP screencap:
Screen.Recording.2024-10-17.at.12.25.18.PM.mov
Reviewers
Checklist
Refactor to better abstraction for going fromThere are some refactors that could be good for a future PR, but I think we should mostly leave it for now.ReturnType<queryRenderFeatures>
-> various map actionsScreenshots (if applicable):