Fixes #12: Set useTmpDir to true. #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since options can't have a default value of `true` (see https://robo.li/getting-started/#options), we had to revert the option for the command, so that it still uses the temporary directory to create the archive.
daften
suggested changes
Sep 28, 2018
Jelle-S
force-pushed
the
feature/issue-#12
branch
from
4b873a7
to
dd63bc4
Compare
Jelle-S
force-pushed
the
feature/issue-#12
branch
from
dd63bc4
to
6ad3dd0
Compare
daften
reviewed
Oct 2, 2018
Moved 'Fixed' lines to separate sections.
daften
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
See https://keepachangelog.com/en/1.0.0/ for the keywords to use. @Jelle-S
Jelle-S
force-pushed
the
develop
branch
9 times, most recently
from
1fb33de
to
c941699
Compare
Jelle-S
force-pushed
the
feature/issue-#12
branch
from
9e246c0
to
71541a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.