Skip to content

Commit

Permalink
Merge branch 'develop'
Browse files Browse the repository at this point in the history
Merge details:

commit 85259b7
Author: Jelle Sebreghts <[email protected]>
Date:   Tue Jul 2 16:29:40 2019

    Refactoring to move away from monolithic RoboFile.

    - Use the command builder
    - Define task classes and traits

    Why we use traits instead of command classes.

     Command classes define a command. Each public method on a RoboFile (in
     the root of the project) is also a command. Public methods can be
     overridden by the RoboFile. Command classes cannot (at least not in a
     reliable way, there's no way of telling robo which of the command
     classes that define a command with the same name, is the actual command
     you want to use).

     I also introduced TraitDependencyCheckerTrait (not my proudest moment),
     because traits cannot extend other traits, but some have overlapping
     functionality, and, you know, DRY. This trait helps other traits define
     dependencies (on yet some other traits) and checks if these
     dependencies are met. Just add a method named
     get[MyTraitClassName]Dependencies, and return an array of full trait
     names (with namespace). If the class using this trait doesn't also use
     every dependend trait, an exception will be thrown.

     Also: Roave/BetterReflection#486
  • Loading branch information
Jelle-S committed Jul 10, 2019
2 parents 02d05cb + 52847fa commit 8818b91
Show file tree
Hide file tree
Showing 28 changed files with 2,452 additions and 1,403 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ env:
language: php
php:
- 7.1
- 7.0
- 7.2
- 7.3
before_script:
- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
- chmod +x ./cc-test-reporter
Expand Down
5 changes: 3 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@
"prefer-stable": true,
"require": {
"digipolisgent/robo-digipolis-package": "^0.1",
"digipolisgent/robo-digipolis-deploy": "^0.1.4",
"digipolisgent/robo-digipolis-deploy": "^0.1.9",
"digipolisgent/robo-digipolis-general": "^0.1",
"gordalina/cachetool": "^3|^2.1|^1.11",
"digipolisgent/command-builder": "^1.0"
"digipolisgent/command-builder": "^1.2.1",
"roave/better-reflection": "^3.0|^2.0"
},
"require-dev": {
"phpunit/phpunit": "~4.4"
Expand Down
Loading

0 comments on commit 8818b91

Please sign in to comment.