Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional type support in serialization layer #102

Merged
merged 16 commits into from
Nov 8, 2023
Merged

Additional type support in serialization layer #102

merged 16 commits into from
Nov 8, 2023

Conversation

chriso
Copy link
Contributor

@chriso chriso commented Nov 7, 2023 •
edited
Loading

The serialization layer can now handle:

  • nil function pointers
  • certain unsafe.Pointer values (nil, and pointers that point to some other object in the serializable graph)
  • many types of reflect.Value

pelletier
pelletier approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@pelletier pelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you had to deal with this!

@chriso chriso merged commit 2f8a3d2 into main Nov 8, 2023
2 checks passed
@chriso chriso deleted the more-types branch November 8, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelletier pelletier pelletier approved these changes

@achille-roussel achille-roussel Awaiting requested review from achille-roussel

@Pryz Pryz Awaiting requested review from Pryz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriso @pelletier