fix: xattr table index to split position into decompressed and compressed offset #277
Conversation
| //nolint:unparam,unused,revive // this does not use offset or compressor yet, but only because we have not yet added support | ||
| func parseXattrsTable(bUIDXattr, bIndex []byte, offset uint64, c Compressor) (*xAttrTable, error) { | ||
| //nolint:unparam,unused,revive // this does not use compressor yet, but only because we have not yet added support | ||
| func parseXattrsTable(bUIDXattr, bIndex []byte, offsetMap map[uint32]uint32, c Compressor) (*xAttrTable, error) { |
There was a problem hiding this comment.
not sure if this was the plan for offset but I replaced it
There was a problem hiding this comment.
This is better. You can see the comment. Does it no longer need the nolint comments? Or is c Compressor still unused?
There was a problem hiding this comment.
Yeah Compressor is still unused, I can remove it if you want
|
Strange that this fails lint on what you did not touch. I will look. |
|
This is the oddest thing. I am running the same version of golangci-lint (v1.61.0), the same minor versions of go (tried with v1.23.0 and v1.23.1, while CI is running v1.23.4), and yet I do not see that lint complaint. |
|
OK, now I got it. It only seems to occur on your branch, even though you didn't change that file. I don't know why. Either way, can you put in a nolint comment on it to clear it? Just run |
| @@ -68,7 +68,7 @@ func TestValidateBlocksize(t *testing.T) { | |||
|
|
|||
| func TestParseXAttrsTable(t *testing.T) { | |||
| // parseXattrsTable(bUIDXattr, bIndex []byte, offset uint64, c compressor) (*xAttrTable, error) { | |||
| b, offset, err := testGetInodeMetabytes() | |||
| b, _, err := testGetInodeMetabytes() | |||
There was a problem hiding this comment.
ahh this is why linting is failing, looks like this was the only place using the offset
|
Now it's happy. Thanks! |
fixes: /issues/276