bump go version, add linter fixes #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
fix-1.23-lint-errors
branch
from
f28d435 to
e315dd3
Compare
AkihiroSuda
reviewed
Oct 2, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/diskfs/go-diskfs | |||
|
|
|||
| go 1.21 | |||
| go 1.23 | |||
There was a problem hiding this comment.
Was there any reason to drop the support for Go 1.22?
There was a problem hiding this comment.
Not particularly. It kind of went along with other flows. We can step it back. Open a PR and make sure it passes lint and tests, and happy to merge it in.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.