Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full tags for signing #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ See [the Oracle specifications](./Oracle.md#oracle-announcements) for more detai
* [`x_point`:`oracle_public_key`]
* [`oracle_event`:`oracle_event`]

where `signature` is a Schnorr signature over a sha256 hash of the serialized `oracle_event`, using the tag `announcement/v0`.
where `signature` is a Schnorr signature over a sha256 hash of the serialized `oracle_event`, using the tag `DLC/oracle/announcement/v0`.

### The `oracle_attestation` Type

Expand Down
2 changes: 1 addition & 1 deletion Oracle.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ UTF-8 is chosen as being a widely supported and easy to implement encoding forma
For numerical outcomes represented in bases greater than 10, each digit should be converted to base 10 before being encoded (note that base 10 numbers in UTF-8 take values in the 0x0030-0x0039 range).
This helps preventing any confusion about the capitalization of letters or the introduction of non-standard characters.

Signing should be done using the [signing algorithm](#Signing-Algorithm) using the tag `attestation/v0`.
Signing should be done using the [signing algorithm](#Signing-Algorithm) using the tag `DLC/oracle/attestation/v0`.

### Serialization of event descriptors

Expand Down