Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewording and Renaming clean-up #142

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

nkohen
Copy link
Contributor

@nkohen nkohen commented Feb 17, 2021

No description provided.

@nkohen nkohen added the documentation Improvements or additions to documentation label Feb 17, 2021
@nkohen nkohen requested a review from Tibo-lg February 17, 2021 21:35
Copy link
Member

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things unclear to me but might not be due to your changes, though it might be a good opportunity to make them clearer


Transaction finalization is not implying a mandatory key material access.[ FIXME: Client Key Management. ]
Transaction finalization does not imply a mandatory key material access. [ FIXME: Client Key Management. ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really about this change but I personally don't get the meaning of this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know what this is saying @ariard ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to review

Cleaned up a couple sentences
@nkohen nkohen merged commit 898e81a into discreetlogcontracts:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants