-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewording and Renaming clean-up #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things unclear to me but might not be due to your changes, though it might be a good opportunity to make them clearer
|
||
Transaction finalization is not implying a mandatory key material access.[ FIXME: Client Key Management. ] | ||
Transaction finalization does not imply a mandatory key material access. [ FIXME: Client Key Management. ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really about this change but I personally don't get the meaning of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually know what this is saying @ariard ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded to review Cleaned up a couple sentences
ba509cd
to
14d99ee
Compare
No description provided.