FIX: cannot read property of undefined #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading this component to use the Glimmer topic list, we converted @discourseComputed into value transformers but there's a bit of magic with @discourseComputed when it comes to handling `.` and `null` / `undefined` values. This ensures the same behaviour and prevents the JS error from happening when creating a new topic from the topic list. Meta - https://meta.discourse.org/t/349416
CvX
approved these changes
Jan 30, 2025
I'd say the bug is that there's a null-ish topic in the topic list to begin with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading this component to use the Glimmer topic list, we converted @discourseComputed into value transformers but there's a bit of magic with @discourseComputed when it comes to handling
.andnull/undefinedvalues.This ensures the same behaviour and prevents the JS error from happening when creating a new topic from the topic list.
Meta - https://meta.discourse.org/t/349416