Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: refactor to remove template overrides, add fixes #23

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

awesomerobot
Copy link
Member

@awesomerobot awesomerobot commented Nov 22, 2024

this removes template overrides, and this theme hasn't been maintained for a while so it fixes some CSS that had regressed

removing the template overrides also allows it to work with the ai plugin topic list summary feature

Before:
image

After:
image

@CvX
Copy link
Contributor

CvX commented Nov 25, 2024

  1. Are those contrasting color for visited/not visited topic links expected?
    image
  2. btw fyi 😅 I'll be following up this PR with a modernization changes (I get to slim down my PR after the changes in here 😃)

about.json Outdated Show resolved Hide resolved
Co-authored-by: Jarek Radosz <[email protected]>
@awesomerobot
Copy link
Member Author

awesomerobot commented Nov 26, 2024

  1. Are those contrasting color for visited/not visited topic links expected?
    image

Kind of... the original theme had used a hardcoded purple value for visited links, so I moved this to quaternary and added a color scheme to the theme (it previously had no color scheme of its own)

I guess the gap is that sites currently using the theme won't automatically get switched to its own color scheme? and they end up with the default value for quaternary, which is red 🤔

@awesomerobot
Copy link
Member Author

Instead of the color palette I've moved the visited link color to a variable, this will avoid sites updating the theme ending up in a state with red as the visited link color

@awesomerobot awesomerobot requested a review from CvX November 27, 2024 14:30
@awesomerobot awesomerobot merged commit 914f969 into main Nov 27, 2024
3 checks passed
@awesomerobot awesomerobot deleted the refactor-remove-overrides branch November 27, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants