Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Show all events in past (add deleted_at in discourse_calendar_post_event_dates) + add show_past_event in settings #199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ledadu
Copy link

@ledadu ledadu commented Dec 18, 2021

Add delete_at in discourse_calendar_post_event_dates and show all events in past + add show_past_event in plugin settings

commit 1d27f67

  • Add delete_at to separate concept of finish_at

  • Add show_past_event in admin plugin
    image
    image

  • I make migration sql queries.

  • translation of admin option is missing

…nts in past + add show_past_event in settings
@ledadu ledadu changed the title Add delete_at in discourse_calendar_post_event_dates and show all events in past + add show_past_event in settings Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Dec 19, 2021
@ledadu ledadu changed the title Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Feature : Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Dec 19, 2021
@ledadu ledadu changed the title Feature : Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings FEATURE: Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Dec 19, 2021
@ledadu ledadu changed the title FEATURE: Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Draft: FEATURE: Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Dec 19, 2021
@ledadu
Copy link
Author

ledadu commented Dec 19, 2021

I found a bug on widget event_list :
image
The widget must not show past events !
I will fix the null title also.. ^^

@ledadu ledadu changed the title Draft: FEATURE: Show all events in past (add delete_at in discourse_calendar_post_event_dates) + add show_past_event in settings Draft: FEATURE: Show all events in past (add deleted_at in discourse_calendar_post_event_dates) + add show_past_event in settings Dec 20, 2021
@ledadu ledadu changed the title Draft: FEATURE: Show all events in past (add deleted_at in discourse_calendar_post_event_dates) + add show_past_event in settings FEATURE: Show all events in past (add deleted_at in discourse_calendar_post_event_dates) + add show_past_event in settings Dec 26, 2021
@ledadu
Copy link
Author

ledadu commented Dec 26, 2021

Hello.
I made the fix for the widget :
paviliondev/layouts-event-list-widget#2

@ledadu
Copy link
Author

ledadu commented Jan 19, 2022

@lis2
Hello.

@eviltrout eviltrout requested a review from jjaffeux January 20, 2022 18:33
@jjaffeux
Copy link
Contributor

Hi,

  • can you remove all the comments, they are most of the times redundant
  • remove the site setting, I don't think most people will want this so I will prefer not to carry this for now
  • we should have some limit on the max number of events we could return
  • it needs specs

@ledadu
Copy link
Author

ledadu commented Feb 23, 2022

Hi

  • Remove all comments ! :o ok.
  • i will remove the site setting.
  • For the limit of max number of events, we can set a big number (how many ?), and in future a xhr can fetch just the date range for the calendar view.
  • The specs is the unit test ? I will try to do this.

@ledadu
Copy link
Author

ledadu commented Feb 25, 2022

I've got issues on my developement environment.
I must reinstall that to change the Pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants