FEATURE: Make it possible to reassign posts on the topic level assign modal #562
Conversation
AndrewPrigorshnev
force-pushed
the
feature/make-possible-to-reasign-posts-in-the-topic-level-assign-modal-alt
branch
3 times, most recently
from
d77dfad
to
c3214f0
Compare
|
|
||
| async #assign() { | ||
| for (const assignment of this.assignments) { | ||
| if (assignment.isEdited) { |
There was a problem hiding this comment.
We don't send server requests for assignments that have not been edited. In case user edits several assignments, it will send several requests to the server. I'm not sure if it's worth introducing a server method here to do all that in one request, but it may be done in a separate PR in the future if case we decide we want it.
| import { tracked } from "@glimmer/tracking"; | ||
| import EmberObject from "@ember/object"; | ||
|
|
||
| export class Assignment extends EmberObject { |
There was a problem hiding this comment.
I've introduced this model, but I haven't migrated all code to using it because that would extend the refactoring surface too much. It would be great to slowly migrate all code to using it, I think that will help simplify the code of the plugin. Now it contains only fields, but as soon as more code start using it, it will become possible to move domain logic in here.
AndrewPrigorshnev
changed the title
… modal This adds a new dropdown to the topic level assign modal. A topic may contain several assignments, the topic itself may be assigned and also some of the replies may be assigned. With this new dropdown, it's possible now to edit all the assignments in one go.
jjaffeux
force-pushed
the
feature/make-possible-to-reasign-posts-in-the-topic-level-assign-modal-alt
branch
from
c3214f0
to
0f22e6e
Compare
jjaffeux
deleted the
feature/make-possible-to-reasign-posts-in-the-topic-level-assign-modal-alt
branch
This adds a new dropdown to the topic level assign modal. A topic may contain several assignments, the topic itself may be assigned and also some of the replies may be assigned. With this new dropdown, it's possible now to edit all the assignments in one go: