FIX: Assignments limit shouldn't prevent from reassigning a post #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPrigorshnev
force-pushed
the
fix/assignment-limit-shouldnt-prevent-from-reassigning-a-post
branch
from
95981fc to
67e7c2c
Compare
AndrewPrigorshnev
force-pushed
the
fix/assignment-limit-shouldnt-prevent-from-reassigning-a-post
branch
from
67e7c2c to
ac760c2
Compare
jjaffeux
reviewed
Mar 26, 2024
spec/lib/assigner_spec.rb
Outdated
| @@ -264,6 +264,21 @@ def assigned_to?(assignee) | |||
| expect(second_assign[:success]).to eq(true) | |||
| end | |||
|
|
|||
| it "assignments limit doesn't prevent from reassigning a post" do | |||
There was a problem hiding this comment.
thats not a very english sentence
ZogStriP
reviewed
Mar 28, 2024
spec/lib/assigner_spec.rb
Outdated
| @@ -264,6 +264,21 @@ def assigned_to?(assignee) | |||
| expect(second_assign[:success]).to eq(true) | |||
| end | |||
|
|
|||
| it "assignments limit doesn't prevent from reassigning a post" do | |||
There was a problem hiding this comment.
How about?
Suggested change
| it "assignments limit doesn't prevent from reassigning a post" do | |
| it "reassigns even when at the assignments limit" do |
There was a problem hiding this comment.
Sounds good, with one detail that we should explicitly mention that this test is for reassigning a post. We also reassign topics sometimes.
ZogStriP
approved these changes
Mar 28, 2024
AndrewPrigorshnev
deleted the
fix/assignment-limit-shouldnt-prevent-from-reassigning-a-post
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, it's possible to have maximum 5 assignments per topic (that includes topic and post assignments). When trying to assign more, this message appears:
One possible edge case here is reassigning a topic or a post. Reassignment doesn't lead to exceeding the limit, and therefore it should be possible. But at the moment we handle correctly only topic reassignments, while when reassigning a post, we show the error message "the limit has been reached".
This PR makes post reassignments work correctly too.