chore(WebSocketShard): improve zlib-sync errors #10808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Qjuh
approved these changes
May 2, 2025
almeidx
reviewed
May 2, 2025
|
I can't reproduce that test failure locally, not sure what happened there? |
almeidx
previously requested changes
May 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10808 +/- ##
==========================================
- Coverage 39.66% 37.97% -1.69%
==========================================
Files 249 251 +2
Lines 15206 15987 +781
Branches 1456 1477 +21
==========================================
+ Hits 6031 6071 +40
- Misses 9163 9904 +741
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iCrawl
approved these changes
Jun 2, 2025
didinele
approved these changes
Jun 2, 2025
github-project-automation
bot
moved this from Review in Progress
to Review Approved
in discord.js
almeidx
approved these changes
Jun 2, 2025
vladfrangu
requested changes
Jun 2, 2025
| new Error(`${this.zLibSyncInflate.err}${this.zLibSyncInflate.msg ? `: ${this.zLibSyncInflate.msg}` : ''}`), | ||
| ); | ||
| // Must be here because zlib-sync is lazily loaded | ||
| const ZlibErrorCodes = { |
There was a problem hiding this comment.
Cache this in a variable outside the class please, so its computed only once
github-project-automation
bot
moved this from Review Approved
to Review in Progress
in discord.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The current error thrown from
zlib-syncisn't great, and doesn't match what errors fromnode:zliblook like. This brings them more in line withnode:zliberrors.Status and versioning classification: