-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery rack update #8382
Merged
Merged
Battery rack update #8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [webpack](https://github.com/webpack/webpack) from 5.51.1 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.51.1...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…bpack-5.76.0 Bump webpack from 5.51.1 to 5.76.0 in /tgui
Bumps [fastify](https://github.com/fastify/fastify) from 3.20.2 to 3.29.4. - [Release notes](https://github.com/fastify/fastify/releases) - [Commits](fastify/fastify@v3.20.2...v3.29.4) --- updated-dependencies: - dependency-name: fastify dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…stify-3.29.4 Bump fastify from 3.20.2 to 3.29.4 in /tgui
…on5-1.0.2 Bump json5 from 1.0.1 to 1.0.2 in /tgui
hyperioo
approved these changes
Dec 8, 2023
Sprite conflict after merging #8380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes battery racks not working by default
Adds quick-toggles to battery racks
Adds more examine text + the ability to remove batteries either by hand attack or by examine
Fixes code related to capacitor and battery insertion
Adds the new better and updates sprites
Also updates power generator sprites
Why It's Good For The Game
Fix is always good
Testing
Tested on local , built a powerrack from zero , tested insertion and removal , examine removal and hand removal , power charging and discharging.
Also tested the new generator sprites , made sure they update properly.
Changelog
🆑
fix: Fixed Battery racks not working
add: Added the abiltity to remove batteries from the battery racks (by examine or by hand attack)
add: Added visual status updates to the battery rack
add: Added more examine info to the battery racks.
add: Updated power generator sprites (taken from the #8380
fix: Fixed battery racks not accepting new batteries / capacitors
balance: Battery racks no longer require 3 cells by default , they now require 1 capacitor and 20 cable coil
/:cl: