-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excelsior machinery only works shipside #8366
Merged
hyperioo
merged 7 commits into
discordia-space:master
from
Firefox13:excelsior-machinery
Nov 24, 2023
Merged
Excelsior machinery only works shipside #8366
hyperioo
merged 7 commits into
discordia-space:master
from
Firefox13:excelsior-machinery
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox13
commented
Nov 18, 2023
Merged
…V-Eris into excelsior-machinery
Firefox13
commented
Nov 18, 2023
@@ -6,9 +6,9 @@ | |||
welcome_text = "You are Excelsior, Ever Upward. You have infiltrated this vessel to further the Revolution.\n\ | |||
The People's strength lies in securing our position, gathering the oppressed, spreading propaganda and producing arms and armor for the final revolution. A methodical approach is recommended. \n\n\ | |||
Our first phase is to retrieve the cache of manufacturing materials and circuit boards. Without a means of production our revolution is in peril.\n\n\ | |||
Our second phase is to establish a fortified position in secret. The People will send additional resources through the teleporter once it is established. This and our autolathe can be protected further with turrets and shield generators, in addition to loyal comrades.\n\n\ | |||
Our second phase is to establish a fortified position in secret. The People will send additional resources through the teleporter once it is established. This and our autolathe can be protected further with turrets and shield generators, in addition to loyal comrades. <b>To prevent technology theft, your machinery, but not handheld weapons, implanters, and armor, is designed to work only on target vessel, CEV \"Eris\" in your case.</b>\n\n\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It refused to work with [station_name()] here.
Firefox13
commented
Nov 18, 2023
hyperioo
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes excelsior machinery only work shipside (on Eris) by adding a check to area on power check. Also uncapitalizes few names and fixes boombox bad English as well as makes it reduce VIG (it's distracting...) instead of TGH. Not sure if it's logical actually. Added some text when implanted for this as a warning.
Why It's Good For The Game
Promotes less "sitting somewhere off-limits" and more aggressive gameplay.
Testing
default.mov
default.mov
(neither deepmaint should)
Changelog
🆑 Firefox13, TheShown, vode-code
balance: Excelsior machinery now only works on Eris. Pulsar, Dungeon, Asteroids etc. turn them off.
balance: Boombox now decreases Vigilance instead of Toughness for non-communists.
spellcheck: Warning about Excelsior machinery working only shipside when becoming an excelsior.
spellcheck: Several names were un-capitalized
spellcheck: Boombox message flavour text
/:cl: