Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excelsior machinery only works shipside #8366

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

Firefox13
Copy link
Contributor

@Firefox13 Firefox13 commented Nov 18, 2023

About The Pull Request

Makes excelsior machinery only work shipside (on Eris) by adding a check to area on power check. Also uncapitalizes few names and fixes boombox bad English as well as makes it reduce VIG (it's distracting...) instead of TGH. Not sure if it's logical actually. Added some text when implanted for this as a warning.

Why It's Good For The Game

Promotes less "sitting somewhere off-limits" and more aggressive gameplay.

Testing

default.mov
default.mov

изображение
(neither deepmaint should)

Changelog

🆑 Firefox13, TheShown, vode-code
balance: Excelsior machinery now only works on Eris. Pulsar, Dungeon, Asteroids etc. turn them off.
balance: Boombox now decreases Vigilance instead of Toughness for non-communists.
spellcheck: Warning about Excelsior machinery working only shipside when becoming an excelsior.
spellcheck: Several names were un-capitalized
spellcheck: Boombox message flavour text
/:cl:

@Firefox13 Firefox13 mentioned this pull request Nov 18, 2023
@@ -6,9 +6,9 @@
welcome_text = "You are Excelsior, Ever Upward. You have infiltrated this vessel to further the Revolution.\n\
The People's strength lies in securing our position, gathering the oppressed, spreading propaganda and producing arms and armor for the final revolution. A methodical approach is recommended. \n\n\
Our first phase is to retrieve the cache of manufacturing materials and circuit boards. Without a means of production our revolution is in peril.\n\n\
Our second phase is to establish a fortified position in secret. The People will send additional resources through the teleporter once it is established. This and our autolathe can be protected further with turrets and shield generators, in addition to loyal comrades.\n\n\
Our second phase is to establish a fortified position in secret. The People will send additional resources through the teleporter once it is established. This and our autolathe can be protected further with turrets and shield generators, in addition to loyal comrades. <b>To prevent technology theft, your machinery, but not handheld weapons, implanters, and armor, is designed to work only on target vessel, CEV \"Eris\" in your case.</b>\n\n\
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refused to work with [station_name()] here.

@hyperioo hyperioo merged commit 6c825a7 into discordia-space:master Nov 24, 2023
@Firefox13 Firefox13 deleted the excelsior-machinery branch November 26, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants