Multiple mech related fixes #8363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing section is not to say "yeah I tested it" but to describe how you actually tested it. Please you made like 4 hotfixes for 2 PRs even if it's a simple variable change, do test it and describe how you tested it. |
I tested it by running it on local , walking over a landmine with a mech , swinging at plants and examining the blade. |
hyperioo
reviewed
Nov 17, 2023
hyperioo
reviewed
Nov 17, 2023
Comment on lines
+531
to
+532
| // You can only fail with tools you are holding | ||
| if(user && T.loc == user) |
There was a problem hiding this comment.
And a quick fix to tool code am I right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes landmines not triggering over mechs due to a runtime
Fixes SWING_ATTACK not attacking plants in general
Fixes mech blades having the wrong description , and their ability to embed into the user.
Why It's Good For The Game
Fixes
Testing
Ran on local
Changelog
🆑
fix:Fixes landmines not triggering over mechs due to a runtime
fix:Fixes SWING_ATTACK not attacking plants in general
fix:Fixes mech blades having the wrong description , and their ability to embed into the user.
/:cl: